Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process config files as golang templates #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dbevacqua
Copy link

Environment variables are available inside the template. Existing functionality is unchanged - the template execution is a no-op if the template is plain yml

@dbevacqua
Copy link
Author

Fixes #40

@dbevacqua
Copy link
Author

@free any thoughts about this?

@free
Copy link
Owner

free commented Oct 29, 2019

Apologies for the delay. Would it be possible to have a test for this? May also be useful as documentation.

@dbevacqua
Copy link
Author

Sure. Do you have a template for this? I can't seem to find any tests in the repo.

@free
Copy link
Owner

free commented Nov 1, 2019

Sure. Do you have a template for this? I can't seem to find any tests in the repo.

Yeah, that's because there aren't any. )o:

But it's never too late to add some. Just go wild and maybe I'll follow suit when I can find some time.

@burningalchemist
Copy link
Contributor

@free I think I'll take care of these tests, so will provide them soon for you to take a look. The template works well, so in Kubernetes use case, for example, we can keep connection strings with passwords out of config. :)

@rmccarthy-ellevation
Copy link

Is this going to be merged anytime soon?

@dannykopping
Copy link

➕ I'd love this functionality too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants