Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SBI to R17 #25

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Upgrade SBI to R17 #25

wants to merge 15 commits into from

Conversation

yccodr
Copy link
Contributor

@yccodr yccodr commented Jul 11, 2024

Description

This PR upgrades the Service Based Interface (SBI) from Release 15 to Release 17.

Changes

  • Updated API endpoints to comply with R17 specifications (new added endpoints will respond 501 Not Implemented)
  • Modify API handlers to comply with new OpenAPI data model
  • Add parameter validator to some endpoints

Left Undone

These are not planed in this PR.

  • Support of NSAG (Network Slice AS Group)
  • Support of ONSSAI
  • Two endpoints
    1. OPTIONS /nnssf-nssaiavailability/v1/nssai-availability
    2. PATCH /nnssf-nssaiavailability/v1/nssai-availability/subscriptions/{subscriptionId}

@andy89923 andy89923 self-requested a review July 11, 2024 10:15
internal/util/util.go Outdated Show resolved Hide resolved
Copy link
Contributor

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

截圖 2024-10-24 上午11 06 11

Check the api version number of sbi route.

@yccodr yccodr requested a review from andy89923 October 29, 2024 08:45
if err != nil {
if apiErr, ok := err.(openapi.GenericOpenAPIError); ok {
// API error
return apiErr.Model().(*models.ProblemDetails), err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface {} is NFManagement.DeregisterNFInstanceError, not *models.ProblemDetails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants