Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto detection of Language #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add auto detection of Language #178

wants to merge 1 commit into from

Conversation

Remeic
Copy link

@Remeic Remeic commented Oct 3, 2018

Issue related to #9

Add auto detection of language using navigator.language, i create an object with key and value.
Keys are the values can be returned by navigator.languages ( list here ) and values are our label for i18n translation files.

Navigator language is set to lowercase for support also safari < 10.2 (here)

I wanted to add test too, but test suite pass every time, even if i try to write test that fail.

I hope my contribution can be useful

@amenak77
Copy link

amenak77 commented Oct 7, 2018

@Remeic we will do some old style tests ASAP. ;) thank you very much for your contribution; feel free to choose another issue if you want to. Bye, Alberto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants