Skip DogtagCertsConfigCheck for PKI versions >= 11.5.0 #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 11.5.0 the PKI project stopped storing the certificate blobs in CS.cfg. If we continue to check it we will report a false positive so skip it in that case. Fixes: freeipa#317 Signed-off-by: Rob Crittenden <[email protected]>
|
@rcritten thanks for the patch, works for me. Tested with dogtag-pki-server 11.3.1-1 and 11.5.0-0.1.alpha4 on fedora 38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 11.5.0 the PKI project stopped storing the certificate blobs in CS.cfg. If we continue to check it we will report a false positive so skip it in that case.
Fixes: #317