IPAOpenSSLChainValidation: ignore default trust store #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe that this is due to ca-certificates adding directory hash links to /etc/pki/tls/certs and dropping the PEM bundle file. This was introduced in ca-certificates-2024.2.69_v8.0.303-5. The bundle will be restored (it is in distgit now but isn't built/released yet). This code worked previously because a specific CAfile was specified so that the global trust wasn't loaded, only the provided file. With these hash directories in place the global trust is loaded via those. So I guess my ask is that for historical purposes you mention at least that this affects Fedora 42/rawhide. |
The check IPAOpenSSLChainValidation is ensuring that the whole certification chain is present in IPA for httpd and RA certificates. It internally calls openssl verify -CAfile /etc/ipa/ca.crt. With the latest version of ca-certificates package shipped in rawhide/Fedora 42, openssl verify also uses the default trust store. Since the test wants to check the chain presence in /etc/ipa/ca.crt, add the -no-CAfile -no-CApath and -no-CAstore options to ensure that only /etc/ipa/ca.crt is used as trusted source. Fixes: freeipa#340 Signed-off-by: Florence Blanc-Renaud <[email protected]>
|
Updated the commit message: |
|
ack, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check IPAOpenSSLChainValidation is ensuring that the whole certification chain is present in IPA for httpd and RA certificates.
It internally calls openssl verify -CAfile /etc/ipa/ca.crt.
With the latest version of ca-certificates package, openssl verify also uses the default trust store. Since the test wants to check the chain presence in /etc/ipa/ca.crt, add the -no-CAfile -no-CApath and -no-CAstore options to ensure that only /etc/ipa/ca.crt is used as trusted source.
Fixes: #340