ipatests: ignore nsslapd-accesslog-logbuffering WARN in healthcheck #7074
Conversation
There was a problem hiding this comment.
Hi @rcritten
the tests test_integration/test_ipahealthcheck.py::TestIpaHealthCLI::test_severity, test_integration/test_ipahealthcheck.py::TestIpaHealthCLI::test_input_file, test_integration/test_ipahealthcheck.py::TestIpaHealthCLI::test_pki_healthcheck and test_integration/test_replica_promotion.py::TestHiddenReplicaPromotion::test_ipahealthcheck_hidden_replica also need to exclude DSCLE0004.
|
temp_commit is failing with known issues https://pagure.io/freeipa/issue/9478 and https://pagure.io/freeipa/issue/9400 |
|
test_commit3 is failing with https://pagure.io/freeipa/issue/9463 (ipa-ods-exporter crashing) |
|
Rebased to pull in fix for https://pagure.io/freeipa/issue/9460 |
|
The remaining issue for temp_commit appears to be fixed upstream in freeipa/freeipa-healthcheck#313 |
|
The failure in |
|
I'm working on upstream freeipa-healtcheck changes in coordiation with ipatests changes to get IdM CI passing. |
rcritten
force-pushed
the
issue_9400
branch
2 times, most recently
from
938e160
to
2e917a9
Compare
| conf = host.get_file_contents( | ||
| '/etc/ipahealthcheck/ipahealthcheck.conf', encoding='utf-8' | ||
| ) | ||
| conf += '[excludes]' |
There was a problem hiding this comment.
If you wanted to check, if the section is already there and avoid failure or be able to add multiple exclusion, something like this would probably also work
config_data = host.get_file_contents(config, encoding='utf-8')
cfg = RawConfigParser()
cfg.read_string(config_data)
# add section "excludes" if it doesn't exist
excludes_section = "excludes"
if not cfg.has_section(excludes_section):
cfg.add_section(excludes_section)
# add options to the excludes section
for option, value in excluded_checks:
if not cfg.has_option(excludes_section, option):
cfg.set(excludes_section, option, value)
# output to the original config file
or using tasks.remote_ini_file to avoid temp files and stuff
There was a problem hiding this comment.
What's strange is this code worked over multiple runs yesterday, just not the last one I ran for the day.
There was a problem hiding this comment.
Without update_packages=true, the 389-ds version is the one from the vagrant image and it was generated a long time ago (with 389-ds-base-2.3.2-2). With update-packages=true the test downloads the latest version from the updates repo (2.3.7-2), and the check for log buffering was added in 2.3.5.
Log buffering is disabled in the integration tests so we can have all the logs at the end. This is causing a warning to show in the 389-ds checks and causing tests to fail that expect all SUCCESS. Add an exclude for this specific key so tests will pass again. We may eventually want a more sophisiticated mechanism to handle excludes, or updating the config in general, but this is fine for now. Fixes: https://pagure.io/freeipa/issue/9400 Signed-off-by: Rob Crittenden <[email protected]>
ipa-healthcheck commit e69589d5 changed the output when a service keytab is missing to not report the GSSAPI error but to report that the keytab doesn't exist at all. This distinguishes from real Kerberos issues like kvno. Fixes: https://pagure.io/freeipa/issue/9482 Signed-off-by: Rob Crittenden <[email protected]>
|
All tests are green. Link to test_ipahealthcheck.py::TestIpaHealthCheck I need to submit the related changes I made to freeipa-healthcheck into Fedora 38, 39 and rawhide. |
|
Two issues are addressed in freeipa-healthcheck-0.16-2:
|
|
@rcritten thanks for the patch, works for me. You can remove the temp commit and I will ACK when PRCI completes. |
Log buffering is disabled in the integration tests so we can have all the logs at the end. This is causing a warning to show in the 389-ds checks and causing tests to fail that expect all SUCCESS.
Add an exclude for this specific key so tests will pass again.
We may eventually want a more sophisiticated mechanism to handle excludes, or updating the config in general, but this is fine for now.
Fixes: https://pagure.io/freeipa/issue/9400