-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for the website #523
Conversation
@gabrielittner I have a hard time finding a good example for |
The simplest one I can come up with is you have a screen with search. Then you can make the search query the identity and have a |
@@ -0,0 +1,61 @@ | |||
# untilIdentityChanged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabrielittner what do you think about this example and explanation about untilIdentityChanged
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating all of this it's a great improvement. I still need to read the sub state machine and testing parts, but already wanted to leave comments.
|
||
```kotlin | ||
data class Error( | ||
val cause: Throwable, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extreme nit: I really dislike Throwables in state because they lead to all these technical error messages that a user should never see but some websites and apps show to users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, it is also hard to test s data class with exceptions. Will change that example later tonight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with an error message instead of throwable. Was considering removing it completely, but then the docs would change from object Error
to data class Error
somewhen along the way (for the error countdown example) ... Maybe we change it later
@@ -0,0 +1,61 @@ | |||
# untilIdentityChanged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is really nice
Co-authored-by: Gabriel Ittner <[email protected]>
Co-authored-by: Gabriel Ittner <[email protected]>
Co-authored-by: Gabriel Ittner <[email protected]>
Co-authored-by: Gabriel Ittner <[email protected]>
Co-authored-by: Gabriel Ittner <[email protected]>
Co-authored-by: Gabriel Ittner <[email protected]>
Co-authored-by: Gabriel Ittner <[email protected]>
Co-authored-by: Gabriel Ittner <[email protected]>
Co-authored-by: Gabriel Ittner <[email protected]>
Co-authored-by: Gabriel Ittner <[email protected]>
…into update_docs
DON'T merge this yet.
I try to update the docs while we merge the changes into main. Once everything new is released, we can merge this PR too.
It updates:
condition
block replacesinStateWithCondition
.