Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove respondd data which is not mesh relevant #1512

Closed

Conversation

genofire
Copy link

@genofire genofire commented Aug 11, 2018

Those data should not be provided by mesh protocol packages.
(Most of them is duplicated)

DO NOT MERGE without Merge of freifunk-gluon/packages#188

@neocturne
Copy link
Member

We can unify this code into a single provider used by both batadv and babel, but we can not remove it, as it is used by the status page.

@neocturne
Copy link
Member

Also, when the providers are unified, the current data format generated by the batadv provider should be preserved for compatiblity.

@genofire
Copy link
Author

Thats what i am working on freifunk-gluon/packages#188

@genofire
Copy link
Author

@christf current state will remove statistics.clients.wifi at babel - batman has it own method to count them

@rotanid rotanid added 0. type: enhancement The changeset is an enhancement 2. status: blocked Marked as blocked because it's waiting on something labels Aug 20, 2018
@neocturne
Copy link
Member

As mentioned in freifunk-gluon/packages#188, I think this information should be moved to the gluon-respondd package.

@genofire genofire changed the title remove respondd data which is not mesh relevant WIP: remove respondd data which is not mesh relevant Apr 10, 2019
@genofire
Copy link
Author

Just for cleanup, in first step only: freifunk-gluon/packages#217

enhancement comes later in: freifunk-gluon/packages#188

@genofire genofire changed the title WIP: remove respondd data which is not mesh relevant remove respondd data which is not mesh relevant Apr 10, 2019
Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything wifi-related has been purged from gluon-mesh-babel and gluon-mesh-batman-adv

@genofire Maybe you can refresh the PR to point out what I'm overlooking or close the PR to reflect it's done.

@@ -444,74 +444,6 @@ static struct json_object * get_traffic(void) {
return ret;
}

static void count_iface_stations(size_t *wifi24, size_t *wifi5, const char *ifname) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count_iface_stations has already been moved to respondd-neighbours.c in 0f1fa24

}
}

static void count_stations(size_t *wifi24, size_t *wifi5) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as count_stations

@genofire
Copy link
Author

This PR is so much outdated and the subject is done.
So lets close it.

Maybe we make a new PR to remove it again, when we/i solve make that parts independent from gluon (without libgluonutils) by:

@genofire genofire closed this Oct 22, 2022
@genofire genofire deleted the remove-not-mesh branch October 22, 2022 14:40
@AiyionPrime
Copy link
Member

This PR is so much outdated and the subject is done.
So lets close it.

What a great idea :P

But thanks for closing it, highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: enhancement The changeset is an enhancement 2. status: blocked Marked as blocked because it's waiting on something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants