Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[FS-41498] : drag drop addon FS usecase with octane upgrade #3

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

preethi-sathiyanarayanan
Copy link

@preethi-sathiyanarayanan preethi-sathiyanarayanan commented Jul 12, 2021

Improvements done to support freshservice :

  1. Converted the addon to Octane.
  2. Introduced "appendTo" to append the dragged card to the passed element instead of the body to afford some CSS styling.
  3. Introduced "preventDragClasses"(array of classes) so on clicking any of these elements within a card, the drag will not be initiated. This is done to accommodate quick actions within the card.
  4. Renamed sortable-item component to sortable-card, since ember-sortable has the same name for one of its components and conflicts with our addon.
  5. Added "addon-test-support/drag.js" to support writing test cases in the host application for drag & drop. => inspired from https://github.com/adopted-ember-addons/ember-sortable/blob/master/addon-test-support/helpers/drag.js
  6. We introduced horizontal sort of swimlanes as well. but it had heavy efforts to get rid of the mouse event conflicts with a card sort. So the dev done for this is commented for now in the PR. Might visit in future.

Bugs and performance fixes done

  1. Dragging a card from the bottom seems to set the placeholder in the wrong position.
  2. as soon as the mouse down happens cloning of the element is done. Moving this to only on start dragging happens, since we have quick actions on the card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant