A couple of changes #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sha1 signature did not work for me. Replaced with SHA256. Also making sure the endpoint ends with '/' -- without it the base string for the signature does not match the original Amazon assumes and signature verification fails. Replaced GET with POST. Not sure why GET does not work, but it does not for me. Added exception catching to the example for Exception::Class newbies like myself.
It's an incompatible change, but without it it simply does not work.
Report ids are 64bit integers, they may overflow perl's integers. There is no math on report IDs, so it's better to treat them as strings.
Report IDs
_GET_FLAT_FILE_PAYMENT_SETTLEMENT_DATA_
_GET_ALT_FLAT_FILE_PAYMENT_SETTLEMENT_DATA_
_GET_PAYMENT_SETTLEMENT_DATA_
were obsoleted on 5/31/2015 and since mid-June do not return any documents.
The are replaced by:
_GET_V2_SETTLEMENT_REPORT_DATA_FLAT_FILE_
_GET_V2_SETTLEMENT_REPORT_DATA_FLAT_FILE_V2_
_GET_V2_SETTLEMENT_REPORT_DATA_XML_
Also fixed syntax for Perl 5.20.2 compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great MWS module, you should push it to CPAN!
I made a couple of fixes while integrating it into the project I'm working on. I hope you find them useful.