fix(no-hover-event): handle undefined variables properly

if a variable cannot be resolved, null is returned. '(null).type' caused an error while running the rule.
frogeducation · Sep 3, 2019 · 09a3637 · 09a3637
1 parent 6347d8b
commit 09a3637
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/rules/no-hover-event.js b/lib/rules/no-hover-event.js
@@ -38,9 +38,7 @@ module.exports = {
 
       const args = node.arguments
 
-      const arg0 = args[0] && args[0].type === 'Identifier'
-        ? resolveIdentifier(args[0], context)
-        : args[0]
+      const arg0 = resolveIdentifier(args[0], context) || args[0]
 
       if (arg0.type !== 'Literal' || arg0.value !== 'hover') return
 

diff --git a/test/lib/rules/jquery-compat/no-hover-event.js b/test/lib/rules/jquery-compat/no-hover-event.js
@@ -11,6 +11,9 @@ ruleTester.run('jquery-compat/no-hover-event', rules['no-hover-event'], {
     },
     {
       code: '$(".foo").hover()'
+    },
+    {
+      code: 'foo.forEach(function(bar) { $quux.on(bar, baz) })'
     }
   ],
   invalid: [