fix(no-null-param): prevent exception when the data object is null

frogeducation · Feb 11, 2020 · 48be78c · 48be78c
1 parent b5ebfbb
commit 48be78c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/rules/no-null-param.js b/lib/rules/no-null-param.js
@@ -62,7 +62,7 @@ module.exports = {
         argumentObject = argumentObject['data']
       }
 
-      if (typeof argumentObject !== "object") { return }
+      if (typeof argumentObject !== "object" || argumentObject === null) { return }
 
       let foundBadValue = badValueWalker(BANNED_VALUES)(argumentObject)
 

diff --git a/test/lib/rules/jquery-compat/no-null-param.js b/test/lib/rules/jquery-compat/no-null-param.js
@@ -22,6 +22,9 @@ ruleTester.run('jquery-compat/no-null-param', rules['no-null-param'], {
       code: `var data = { foo: null };
       data.foo = 42;
       $.ajax("hello", { data: data });`
+    },
+    {
+      code: `$.ajax({ data: null });`
     }
   ],
   invalid: [