Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ランダムに発生するログイン失敗のバグを修正 #5

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

caru-ini
Copy link
Collaborator

@caru-ini caru-ini commented Jul 2, 2024

Types of changes

What kind of change does this PR introduce? (check at least one)

  • Breaking change
  • Bugfix
  • Feature
  • Code style update
  • Refactoring
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

修正後、20回ほどテストを回しましたが、一度も失敗しなかったので、多分治せたと思います

  • 不要なassertを削除
  • 不正な値が出たとき再生成
  • srpAの生成を関数化
  • toBufferに桁数が奇数のときの0パディングを追加

Copy link
Member

@solufa solufa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正速度、内容ともに実務レベルで素晴らしい

@solufa solufa merged commit e0da1ef into frouriojs:main Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants