-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for deserialization of owned values #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've integrated the additional fixes into my PR by cherry-picking your commits!
@@ -54,7 +54,7 @@ use smallvec::SmallVec; | |||
use std::iter::FromIterator; | |||
use std::{error, io, fmt}; | |||
use serde::de::{Visitor}; | |||
use serde::export::{PhantomData}; | |||
use serde::__private::{PhantomData}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we should really be importing this from std, haha.
src/lib.rs
Outdated
@@ -49,12 +49,12 @@ pub mod utils; | |||
pub use config::*; | |||
pub use types::{Error, ParseHexError}; | |||
|
|||
use serde::__private::PhantomData; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invasive things like cargo fmt
are likely better left to individual PRs, just adds unnecessary noise to the diff and thus work to the reviewers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomaseizinger I agree with you, and i reverted the code reformat
commit
This reverts commit fb02c8f.
Closed in favor of #8 |
Based on PR #8 but includes: