Refresh credentials to check validity #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently this is not how to call refresh? |
|
ping |
The original call to credentials.valid does not work until the credential has been refreshed once, as discussed in fsspec#486. This instead checks if the credential will work by trying to connect
baxen
force-pushed
the
baxen/connect-cloud-valid
branch
from
2d11b68
to
8100697
Compare
|
Can someone with a GCP instance to hand please check this? |
|
OK, I am convinced - this is going in. Thanks @baxen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original call to credentials.valid does not work until the
credential has been refreshed once, as discussed in #486. This
instead checks if the credential will work by trying to connect