New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upath core tests #130

Merged

ap-- merged 4 commits into fsspec:main from ap--:fix-upath-core-tests

Aug 6, 2023

Collaborator

ap-- commented Aug 6, 2023

This fixes 3 issues with the test_core.py tests:

tests using gcsfs were using anon=True as a storage option, where they should have used token='anon'
the tests checking interaction between multiple filesystems didn't need the backend fixtures to test if there is no interference
some tests incorrectly passed storage_options via a storage_options kwarg (this is not current behavior)

And it moves the local "file://" tests to their own implementations/test_local.py submodule (to add more local filesystem tests in the future).

ap-- added 4 commits

August 6, 2023 14:45


          tests: test_core pass storage_options correctly

2ffbf6b


          tests: test_core gcs tests need token='anon'

3d8dbd7


          tests: test_core test multiple filesystem interaction without s3_fixture

d1bda9d


          tests: move file:// tests to test_local implementation

f27a20d

ap-- merged commit 53b5710 into fsspec:main

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet