Implementation registration #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap--
force-pushed
the
implementation-registration
branch
from
a7e2122
to
a8e0e78
Compare
|
Any concerns regarding this PR @normanrz ? I think it'll help a few users out there, that are currently registering custom implementations via modifying the private |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #99
This PR adds:
upath.registry.available_implementations()which returns a list of protocols for all available UPath implementationsupath.registry.register_implementation()which let's a user register a UPath subclass and it's corresponding protocol dynamicallyand it adds an
"universal_pathlib.implementations"entry point, that let's users register their custom UPath subclasses dynamically via their package metadata.