Inherit from pathlib_abc.PathBase
#270
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A lot of the path parsing in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve maintainability when new Python versions are released and to integrate better with upstream as well as downstream libraries, we're moving to
pathlib_abc.PathBaseas our base class forUPath.This draft PR makes UPath inherit from
PathBase, introducesPureUPath, and a "parser" (formerly 'flavour') based onParserBase.There's still quite a bit of work to be done to make all tests pass, but I'm pushing this here for people to follow along.
This PR will close #114, close #193, close #221 and close #245