Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Star Citizen: Add UmU #193

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

LovingMelody
Copy link
Contributor

This is draft PR for migrating to umu at least for star-citizen to resolve #151
Currently doesn't run (but does build) due to how umu is packaged in their flake

Star Citizen Updates:

• Add attr "useUmu" to support umu:
• Add attr protonPath to set umu's proton version:
This defaults to proton-ge-bin in nixpkgs. To always use the latest
proton-ge you can set this to "GE-Proton"
• Add attr protonVerbs to set proton verbs, only affects umu

Flake lock file updates:

• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/02923630b89aa1ab36ef8e422501a6f4fd4b2016?narHash=sha256-OhysviwHQz4p2HZL4g7XGMLoUbWMjkMr/ogaR3VUYNA%3D' (2024-05-18)
→ 'github:NixOS/nixpkgs/9355fa86e6f27422963132c2c9aeedb0fb963d93?narHash=sha256-%2B%2BTYlGMAJM1Q%2B0nMVaWBSEvEUjRs7ZGiNQOpqbQApCU%3D' (2024-07-16)
• Added input 'umu':
'git+https://github.com/Open-Wine-Components/umu-launcher/?dir=packaging/nix&ref=refs/heads/main&rev=ce78913d68afafca5f695f3ebb1e6a706377480d&submodules=1' (2024-07-18)
• Added input 'umu/nixpkgs':
follows 'nixpkgs'

pkgs/star-citizen/default.nix Outdated Show resolved Hide resolved
pkgs/star-citizen/default.nix Outdated Show resolved Hide resolved
@LovingMelody LovingMelody force-pushed the star-citizen-umu branch 2 times, most recently from ce85384 to 116c4aa Compare July 20, 2024 00:52
@LovingMelody
Copy link
Contributor Author

I have confirmed that this is now running correctly.

@LovingMelody LovingMelody marked this pull request as ready for review July 20, 2024 01:01
Star Citizen Updates:

• Add attr "useUmu" to support umu:
• Add attr protonPath to set umu's proton version:
    This defaults to proton-ge-bin in nixpkgs. To always use the latest
    proton-ge you can set this to "GE-Proton"
• Add attr protonVerbs to set proton verbs, only affects umu

Flake Lock Update:
• Added input 'umu':
    'git+https://github.com/Open-Wine-Components/umu-launcher/?dir=packaging/nix&ref=refs/heads/main&rev=845da38a0088a2c6325be9fa4fb9ab542db3887f&submodules=1' (2024-07-18)
• Added input 'umu/nixpkgs':
    follows 'nixpkgs'

GitHub Workflow Changes:

• Added umu to build workflow
Copy link
Owner

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fufexan fufexan merged commit 9d4bca9 into fufexan:master Jul 20, 2024
9 checks passed
@LovingMelody LovingMelody deleted the star-citizen-umu branch July 20, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to umu?
2 participants