Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tab bar layout on ipad #2

Closed
wants to merge 1 commit into from
Closed

fix: tab bar layout on ipad #2

wants to merge 1 commit into from

Conversation

jleach
Copy link
Member

@jleach jleach commented Sep 6, 2023

Summary of Changes

Fix an issue where the tab bar notificate badge gets out of alignmetn on iPad.

Related Issues

Fixed bcgov/bc-wallet-mobile#1428

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach self-assigned this Sep 6, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@c7df78f). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   59.21%           
=======================================
  Files           ?      176           
  Lines           ?     4985           
  Branches        ?     1400           
=======================================
  Hits            ?     2952           
  Misses          ?     2008           
  Partials        ?       25           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jleach jleach closed this Sep 6, 2023
@jleach jleach reopened this Sep 6, 2023
@jleach jleach closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification badge location wrong on iPad
2 participants