makefile updates #484
Merged
makefile updates #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LOL ty! :D |
gpassini
approved these changes
Sep 9, 2024
| @@ -44,7 +42,9 @@ docker: | |||
| generate: .tmp/protoc/bin/protoc | |||
| @go install google.golang.org/protobuf/cmd/protoc-gen-go@a709e31e5d12 | |||
| @go install google.golang.org/grpc/cmd/[email protected] | |||
| @go install github.com/jhump/protoreflect/desc/sourceinfo/cmd/[email protected] | |||
There was a problem hiding this comment.
What's the reasoning behind generating these src info files?
There was a problem hiding this comment.
IDK, but we do it in grpcui so I just figured parity and reconciling differences probably good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this tweak will allow #483 to pass after rebase... but I'm not sure.