Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Golang 1.23 #485

Merged
merged 3 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,41 +9,32 @@ shared_configs:
# Use the latest 2.1 version of CircleCI pipeline process engine. See: https://circleci.com/docs/2.0/configuration-reference
version: 2.1
jobs:
build-1-19:
build-1-21:
working_directory: ~/repo
docker:
- image: cimg/go:1.19
- image: cimg/go:1.21
steps: *simple_job_steps

build-1-20:
build-1-22:
working_directory: ~/repo
docker:
- image: cimg/go:1.20
- image: cimg/go:1.22
steps: *simple_job_steps

build-1-21:
build-1-23:
working_directory: ~/repo
docker:
- image: cimg/go:1.21
- image: cimg/go:1.23
steps:
- checkout
- run:
name: Run tests and linters
command: |
make ci

# TODO: Need updates to some static analyzer tools to support 1.22. After those
# are updated, move the full linting from 1.21 to this latest release.
build-1-22:
working_directory: ~/repo
docker:
- image: cimg/go:1.22
steps: *simple_job_steps

workflows:
pr-build-test:
jobs:
- build-1-19
- build-1-20
- build-1-21
- build-1-22
- build-1-23
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.21-alpine as builder
FROM golang:1.23-alpine as builder
MAINTAINER Fullstory Engineering

# create non-privileged group and user
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ vet:

.PHONY: staticcheck
staticcheck:
@go install honnef.co/go/tools/cmd/staticcheck@v0.4.3
@go install honnef.co/go/tools/cmd/staticcheck@v0.5.1
staticcheck ./...

.PHONY: ineffassign
Expand All @@ -77,7 +77,7 @@ ineffassign:

.PHONY: predeclared
predeclared:
@go install github.com/nishanths/predeclared@5f2f810c9ae6
@go install github.com/nishanths/predeclared@245576f9a85c
predeclared ./...

# Intentionally omitted from CI, but target here for ad-hoc reports.
Expand Down
Loading