feat(embassy-arch): provide peripheral-independent I2C and SPI types #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROMemories
force-pushed
the
feat/buses-in-arch
branch
from
dcaf827
to
db027b7
Compare
|
Cool! |
ROMemories
force-pushed
the
feat/buses-in-arch
branch
from
532b9ce
to
29f35cf
Compare
ROMemories
commented
Jun 17, 2024
| @@ -15,6 +15,8 @@ members = [ | |||
| "src/riot-rs-macros", | |||
| "src/riot-rs-random", | |||
| "tests/benchmarks/bench_sched_yield", | |||
| "tests/i2c-bus", | |||
| "tests/spi-bus", | |||
There was a problem hiding this comment.
Should we instead introduce another directory in tests, next to benchmarks, so that we can use a wildcard to define crates in that directory as workspace members?
ROMemories
force-pushed
the
feat/buses-in-arch
branch
from
430b38a
to
dae6d23
Compare
ROMemories
commented
Jun 18, 2024
ROMemories
changed the title
ROMemories
changed the title
ROMemories
commented
Jul 16, 2024
ROMemories
force-pushed
the
feat/buses-in-arch
branch
from
2424dab
to
40c2f0d
Compare
ROMemories
force-pushed
the
feat/buses-in-arch
branch
4 times, most recently
from
91fd9e5
to
e591bf0
Compare
ROMemories
force-pushed
the
feat/buses-in-arch
branch
2 times, most recently
from
703e55a
to
07739d9
Compare
This leverages embassy-embedded-hal to provide buses instantiated once and then shared between tasks. This currently only support the RP2040, nRF52840, and the nRF5340. It is however trivial add support for other nRF MCUs.
ROMemories
force-pushed
the
feat/buses-in-arch
branch
from
71757ee
to
0732616
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This leverages
embassy-embedded-halto provide buses instantiated once and then shared between tasks.This is the first step in landing the WIP sensor abstraction piece by piece.
Limitations
Issues/PRs references
Depends on #322
Open Questions
The
dummymodule in thearchmodule would need to be updated, but it's unclear what we should provide in it, as the interface of other archs is not exactly the same because of different requirements (e.g., RP2040 require DMA channels for SPI, and nRF GPIO outputs require anOutputDriverparameter).TODO
Sendbecause of the underlying DMA linked-list, and there is an unresolved SPI mode-related issue)stm32-dataand decide how to distribute the JSON data files required for SMT32Change checklist