Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPD-277] [BUG] Fix setup.sh for the recommendation example #34

Merged
merged 14 commits into from
Jul 27, 2023

Conversation

Christopher-Norman
Copy link
Member

@Christopher-Norman Christopher-Norman commented Jul 25, 2023

scikit-surprise does not provide wheels for installation. Therefore when using a pyproject.toml based virtual environment it will not be able to install scikit-surprise due to not adhering to PEP 517 installing standards. This updates the requirements to install the scikit-surprise library differently.

This PR also updates the CI to fix a bug introduced by Cython3 with pyyaml, described here: yaml/pyyaml#724

@JonoCX JonoCX added the bug Something isn't working label Jul 26, 2023
Comment on lines 49 to 50
sed '/zenml/d' llm/requirements.txt > llm/requirements2.txt
mv llm/requirements2.txt llm/requirements.txt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zenml has been removed from requirements so this is probably not needed.

Copy link
Member

@JonoCX JonoCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@KirsoppJ KirsoppJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Christopher-Norman Christopher-Norman merged commit 9ebc1ee into main Jul 27, 2023
4 checks passed
@Christopher-Norman Christopher-Norman deleted the RPD-277-fix-scikit-surprise-library branch July 27, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants