feat: add list to user collection, add new contracts transfer, burn, add gentk management (cancel, list, burn, transfer) #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add gentk management (cancel, list, burn, transfer)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
louisholley
reviewed
May 9, 2023
| loading={contractLoading} | ||
| success={success} | ||
| error={contractError} | ||
| successMessage="Your gentk has been burn" |
There was a problem hiding this comment.
Suggested change
| successMessage="Your gentk has been burn" | |
| successMessage="Your gentk has been burned" |
louisholley
reviewed
May 9, 2023
| loading={contractLoading} | ||
| success={success} | ||
| error={contractError} | ||
| successMessage="Your Gentk has been transfered" |
There was a problem hiding this comment.
Suggested change
| successMessage="Your Gentk has been transfered" | |
| successMessage="Your Gentk has been transferred" |
louisholley
reviewed
May 9, 2023
| width="530px" | ||
| > | ||
| <div className={style.container}> | ||
| <div>Which price would you like to set your listing ?</div> |
There was a problem hiding this comment.
Suggested change
| <div>Which price would you like to set your listing ?</div> | |
| <div>What price would you like to set for your listing?</div> |
louisholley
reviewed
May 9, 2023
| width="530px" | ||
| > | ||
| <div className={style.container}> | ||
| <div>Which price would you like to list your gentk for ?</div> |
There was a problem hiding this comment.
Suggested change
| <div>Which price would you like to list your gentk for ?</div> | |
| <div>What price would you like to set for your listing?</div> |
louisholley
reviewed
May 9, 2023
| interface Props { | ||
| user: User | ||
| } | ||
| export function UserCollectionGentks({ user }: Props) { | ||
| const { user: userLogged } = useContext(UserContext) | ||
| const [displayMode, setDisplayMode] = useState<"list" | "grid">("list") |
There was a problem hiding this comment.
Suggested change
| const [displayMode, setDisplayMode] = useState<"list" | "grid">("list") | |
| const [displayMode, setDisplayMode] = useState<"list" | "grid">("grid") |
i think we should set grid as default to avoid too much change in the UI
There was a problem hiding this comment.
it was during the WIP, easier to work grid enabled
louisholley
reviewed
May 9, 2023
| @@ -134,77 +120,36 @@ export function UserCollectionGentks({ user }: Props) { | |||
| if (window.scrollY > top + 10) { | |||
| window.scrollTo(0, top) | |||
| } | |||
|
|
|||
| refetch?.({ | |||
There was a problem hiding this comment.
do we not need this refetch?
louisholley
reviewed
May 9, 2023
| @@ -22,14 +22,14 @@ const TabWrapper = ({ children, onClick, ...props }: TabWrapperProps) => ( | |||
|
|
|||
| interface Props { | |||
| user: User | |||
| activeTab: "gentk" | "articles" | "tickets" | |||
| activeTab: "gentk" | "articles" | "tickets" | "manage" | |||
There was a problem hiding this comment.
what's manage here? or not implemented yet?
louisholley
reviewed
May 9, 2023
|
|
||
| success(): string { | ||
| const { objkt } = this.params | ||
| return `You have burn your gentk "${objkt.name}" [insert dramatic sound effect]` |
There was a problem hiding this comment.
Suggested change
| return `You have burn your gentk "${objkt.name}" [insert dramatic sound effect]` | |
| return `You have burned your gentk "${objkt.name}"` |
|
looks great, awesome work! i think we may wanna iron out the styles for this list view a bit: 
|
|
@louisholley all changes are valid, to note than current BurnToken and BurnTokenV3 have the sentence "[insert dramatic music] hence why I did a similar touch on BurnGentk. Tho the branch is still WIP (need batch actions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.