try to coerce zod options schema for FxParamsOption if numeric is string
#843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@digitallyserviced is attempting to deploy a commit to the Fxhash Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So my token was mintable at some point in the past without zod tossing an error up on the params abouot using a string'd numeric for this parameter...
I want to make this free but also want to resolve the error as it is not a huge change to resolve, and as I mentioned, this was not throwing in the past.
This PR will coerce numeric values to a number if possible and be forgiving about passing strings as the options in
FxParamsOptionschemas.https://www.fxhash.xyz/generative/slug/eye-pressure/explore-params