Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JDK8 support #19

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add JDK8 support #19

wants to merge 7 commits into from

Commits on Aug 27, 2020

  1. Added direnv integration

    @fzakaria
    fzakaria committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    fda4e2e View commit details
    Browse the repository at this point in the history

  2. Added a jdk8 and jdk11 attribute for mvn2nix

    @fzakaria
    fzakaria committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    0561074 View commit details
    Browse the repository at this point in the history

  3. Added README

    @fzakaria
    fzakaria committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    a07b44f View commit details
    Browse the repository at this point in the history

  4. Add safeguard for non artifacts

    @fzakaria
    fzakaria committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    e46f963 View commit details
    Browse the repository at this point in the history

  5. Filter unpacked and asc

    @fzakaria
    fzakaria committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    42ded71 View commit details
    Browse the repository at this point in the history

  6. Fix github workflow

    @fzakaria
    fzakaria committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    d86201f View commit details
    Browse the repository at this point in the history

  7. Set JAVA_HOME explicitly 

    Maven only sets JAVA_HOME if its not set.

I suspect that GitHub actions are setting JAVA_HOME; so it's
not getting the JDK11 version and failing to build.
    @fzakaria
    fzakaria committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    41cc1c4 View commit details
    Browse the repository at this point in the history