Predictable artifact order

[jvierling]

On my system the integration test fails (at commit ea21cfe), because the order of the artifacts in the generated lockfile changes slightly. This pull request makes the order of the artifacts more predictable by ordering artifacts alphabetically. The pull request also includes some clean up commits.

[fzakaria]

Maybe add a comment explaining why it needs to be a TreeMap?

Did I have any test in this repo?
I can't remember :)

[fzakaria]

LGTM but please add a comment so we don't lose out why it needs to be a TreeMap.
is there a simple test that can be written to validate they output in order?
If it's too much of a hurdle I wouldn't worry about it.

Thank you for the contribution.

[jvierling]

@fzakaria Thanks for the review. I have added a comment and a unit test that shows that the artifacts are ordered alphabetically. The integration test Maven2nixIT also shows that the artifacts now appear in alphabetic order (see the modifications of the test's expected lockfile).

[fzakaria]

LGTM -- I will spend some time Monday or this week to try and update the GitHub actions and validate it passes.
LMK if you are interested in being a maintainer; I haven't really been maintaining this repository at all.

[jvierling]

FYI I fixed the Github-Actions on my fork (see https://github.com/jvierling/mvn2nix) by removing the cachix/cachix-action, updating the version of the cachix/install-nix-action, and removing the install_url from the flake jobs.

[fzakaria]

Do you want to include the updated github action as part of the PR?
or you can make it a separate PR.

[jvierling]

I'll include the update to the Github Actions as part of the PR. However, I am not sure if removing cachix/cachix-action is an option for you (I removed it on my fork because I do not have a cachix cache).

[fzakaria]

Thank you for the great PR.