Moved outstanding exp-func-imp PR into this PR with latest reorg #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbrush and @ahwagner please review this and let's push it if it's clean enough based on all conversations/decisions to date. We can continue with another PR for the next tranche of changes. Notes from gks-tech sync mtg 11/7
|
|
I added a mock-up of a VarPath statement in the |
larrybabb
commented
Nov 8, 2024
schema/va-spec/base/pathogenicity-evidenceline-profile-source.yaml
Outdated
Show resolved
Hide resolved
larrybabb
commented
Nov 8, 2024
schema/va-spec/base/pathogenicity-evidenceline-profile-source.yaml
Outdated
Show resolved
Hide resolved
ahwagner
requested changes
Nov 8, 2024
schema/va-spec/base/pathogenicity-evidenceline-profile-source.yaml
Outdated
Show resolved
Hide resolved
…mpact profiles. Some questions remain (see comments in test case fixtures)
larrybabb
commented
Nov 8, 2024
schema/va-spec/acmg-2015/pathogenicity-statement-profile-source.yaml
Outdated
Show resolved
Hide resolved
larrybabb
commented
Nov 8, 2024
schema/va-spec/base/experimental-functional-impact-study-statement-profile-source.yaml
Outdated
Show resolved
Hide resolved
larrybabb
commented
Nov 8, 2024
schema/va-spec/base/experimental-functional-impact-study-statement-profile-source.yaml
Outdated
Show resolved
Hide resolved
schema/va-spec/base/experimental-functional-impact-study-statement-profile-source.yaml
Outdated
Show resolved
Hide resolved
schema/va-spec/base/pathogenicity-evidenceline-profile-source.yaml
Outdated
Show resolved
Hide resolved
…y-evidence-line-profile-source.yaml adding dash to evidence-line file name to be consistent with sue of dashes between class names in other profile file names (e.g. study-result)
…yaml Updated comments for discussion/review among developers, based on most recent conversations.
- Updated comments/questions about this profile based on outcomes of recent discussions. - made a couple minor improvements to attribute descriptions.
ahwagner
force-pushed
the
func-impact-for-review
branch
from
6cc1e5b
to
89d4e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the draft for the latest ExpFuncImpact profiles applied to the latest reorg of folders that came out of the ASHG unconference work.
Ready for review, refine, approve and merge after @ahwagner, @mbrush and @larrybabb meet on 11/8/2024.