Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EU banner update: replace call for trainers banner with GTA user registration banner #2754

Merged
merged 1 commit into from
Sep 5, 2024
Merged

EU banner update: replace call for trainers banner with GTA user registration banner #2754

merged 1 commit into from
Sep 5, 2024

Conversation

sanjaysrikakulam
Copy link
Collaborator

FYI: @teresa-m

@sanjaysrikakulam
Copy link
Collaborator Author

@dannon The GA is failing with the error

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more at https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/.

Could you please look into this?

@dannon
Copy link
Member

dannon commented Sep 5, 2024

@sanjaysrikakulam Yep! Looks like they finally pulled the plug on that one. Checking it out.

@sanjaysrikakulam
Copy link
Collaborator Author

@sanjaysrikakulam Yep! Looks like they finally pulled the plug on that one. Checking it out.

Cool! Thank you!

dannon
dannon approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@dannon dannon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload action is fine now (updated to v4) and only affected the cypress tests, this should be good to go but you are welcome to rebase if you want a clean test rerun.

@sanjaysrikakulam
Copy link
Collaborator Author

Upload action is fine now (updated to v4) and only affected the cypress tests, this should be good to go but you are welcome to rebase if you want a clean test rerun.

Thank you! :)

@bgruening bgruening merged commit d7a73f4 into galaxyproject:master Sep 5, 2024
3 checks passed
@teresa-m
Copy link
Contributor

teresa-m commented Sep 5, 2024

Thanks to all of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannon dannon dannon approved these changes

@bgruening bgruening Awaiting requested review from bgruening

@mira-miracoli mira-miracoli Awaiting requested review from mira-miracoli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanjaysrikakulam @dannon @teresa-m @bgruening