-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.0] Allow the legacy DELETE dataset endpoint to accept any string for the history_id #16593
Merged
dannon
merged 4 commits into
galaxyproject:release_23.0
from
assuntad23:bug/16191/boxplot-render-fail
Aug 30, 2023
Merged
[23.0] Allow the legacy DELETE dataset endpoint to accept any string for the history_id #16593
dannon
merged 4 commits into
galaxyproject:release_23.0
from
assuntad23:bug/16191/boxplot-render-fail
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Aug 25, 2023
from https://github.com/galaxyproject/galaxy/actions/runs/5970129798/job/16197211028?pr=16593#step:10:15:
|
assuntad23
changed the title
Bug/16191/boxplot render fail
Allow the legacy DELETE dataset endpoint to accept any string for the history_id
Aug 25, 2023
mvdbeek
approved these changes
Aug 25, 2023
2 tasks
assuntad23
force-pushed
the
bug/16191/boxplot-render-fail
branch
from
August 25, 2023 21:45
25fbac2
to
d8e6098
Compare
martenson
changed the title
Allow the legacy DELETE dataset endpoint to accept any string for the history_id
[23.0] Allow the legacy DELETE dataset endpoint to accept any string for the history_id
Aug 25, 2023
assuntad23
force-pushed
the
bug/16191/boxplot-render-fail
branch
from
August 28, 2023 18:05
d8e6098
to
7bdae4d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
You need to install the dependencies when you switch branches ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #16191
This fix works in cooperation with this PR in galaxy-visualizations
The first part of the fix here was to correct the 400 error, that was unable to decode a history_id for "none", therefore I changed the type of the parameter and it's default (thanks to @mvdbeek for helping me step through that)
After making that change, I made the changes in the galaxy-visualizations repo (with thanks to @dannon) for the tip off
MOVED TO A SEPARATE PR #16598
Finally, I was getting a 200 response, but still was not able to view the chart, whereupon I dug around the dev console long enough to find that target was undefined, since it was misnamed as targets as a parameter. After fixing that, the boxplot renders fine. 😅
How to test the changes?
(Select all options that apply)
License