Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Allow the legacy DELETE dataset endpoint to accept any string for the history_id #16593

Merged

Conversation

assuntad23
Copy link
Contributor

@assuntad23 assuntad23 commented Aug 24, 2023

Fix for #16191

This fix works in cooperation with this PR in galaxy-visualizations
The first part of the fix here was to correct the 400 error, that was unable to decode a history_id for "none", therefore I changed the type of the parameter and it's default (thanks to @mvdbeek for helping me step through that)

After making that change, I made the changes in the galaxy-visualizations repo (with thanks to @dannon) for the tip off

MOVED TO A SEPARATE PR #16598
Finally, I was getting a 200 response, but still was not able to view the chart, whereupon I dug around the dev console long enough to find that target was undefined, since it was misnamed as targets as a parameter. After fixing that, the boxplot renders fine. 😅

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Create a tabular file
    2. Create a boxplot visualization for it
    3. Check the visualization under Users > Visualizations
    4. Note that the graph is visible

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 25, 2023

from https://github.com/galaxyproject/galaxy/actions/runs/5970129798/job/16197211028?pr=16593#step:10:15:

Rebuilding client/src/schema/schema.ts resulted in changes, run 'make update-client-api-schema' and commit results

@assuntad23 assuntad23 changed the base branch from dev to release_22.01 August 25, 2023 14:58
@assuntad23 assuntad23 changed the base branch from release_22.01 to dev August 25, 2023 14:59
@assuntad23 assuntad23 changed the title Bug/16191/boxplot render fail Allow the legacy DELETE dataset endpoint to accept any string for the history_id Aug 25, 2023
@assuntad23 assuntad23 changed the base branch from dev to release_22.05 August 25, 2023 16:50
@assuntad23 assuntad23 changed the base branch from release_22.05 to dev August 25, 2023 16:50
@assuntad23 assuntad23 force-pushed the bug/16191/boxplot-render-fail branch from 25fbac2 to d8e6098 Compare August 25, 2023 21:45
@assuntad23 assuntad23 changed the base branch from dev to release_23.0 August 25, 2023 21:46
@martenson martenson changed the title Allow the legacy DELETE dataset endpoint to accept any string for the history_id [23.0] Allow the legacy DELETE dataset endpoint to accept any string for the history_id Aug 25, 2023
@assuntad23 assuntad23 force-pushed the bug/16191/boxplot-render-fail branch from d8e6098 to 7bdae4d Compare August 28, 2023 18:05
@martenson

This comment was marked as outdated.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 28, 2023

You need to install the dependencies when you switch branches (pip install -r requirements.txt) from the root.

@dannon dannon merged commit 1fcde3a into galaxyproject:release_23.0 Aug 30, 2023
38 checks passed
@galaxyproject galaxyproject deleted a comment from github-actions bot Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants