Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play nice with password managers #18206

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

martenson
Copy link
Member

see details at https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. using a password manager verify whether your password is being suggested/autocompleted on login/registration/pass change pages

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member

mvdbeek commented May 23, 2024

Very cool, thank you!

@mvdbeek mvdbeek merged commit cd779a4 into galaxyproject:dev May 23, 2024
30 of 31 checks passed
@bgruening bgruening deleted the autopass branch May 23, 2024 07:38
@jdavcs jdavcs changed the title play nice with password managers Play nice with password managers May 23, 2024
@jdavcs jdavcs added this to the 24.1 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants