Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modes z and Z for docker volumes #18998

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Allow modes z and Z for docker volumes #18998

wants to merge 7 commits into from

Commits on Oct 15, 2024

  1. allow z and Z for docker volumes

    @bernt-matthias
    bernt-matthias committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    bba7cff View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. allow any ordering in the mode string

    @bernt-matthias
    bernt-matthias committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    753898e View commit details
    Browse the repository at this point in the history

  2. remove unnecessary comprehension

    @bernt-matthias
    bernt-matthias committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8fd56f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. also check for z in the re-duplication code

    @bernt-matthias
    bernt-matthias committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    84cc2cc View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Update lib/galaxy/tool_util/deps/container_volumes.py 

    Co-authored-by: Helena <[email protected]>
    @bernt-matthias @hexylena
    bernt-matthias and hexylena authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    bc161f5 View commit details
    Browse the repository at this point in the history

  2. fix logic

    @bernt-matthias
    bernt-matthias committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2d7cd6f View commit details
    Browse the repository at this point in the history

  3. restructure to make roundtrip testable 

    The combination

- preprocess_volumes which creates Volume objects and creates strings
  again in the end and
- creation of DockerVolumes which are only temporary and are soon
  converted to str again

confused me and needed testing IMO. Also code was redundant.
    @bernt-matthias
    bernt-matthias committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e09cba3 View commit details
    Browse the repository at this point in the history