Improvements to tool test error handling. #19009
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Oct 16, 2024
| try: | ||
| result = response.json() | ||
| except Exception as e: | ||
| raise Exception( |
There was a problem hiding this comment.
Can you dump the status code and response.text ? I would prefer this over a guess
There was a problem hiding this comment.
The only time we know this will happen is Galaxies without this patch - so there will be a huge dump of HTML. I think we keep the guess but also I'll dump that huge page I guess.
There was a problem hiding this comment.
True, and even our expected error messages are json dumps. Maybe move the response.json to below the statsu code check on the next line ? Then I'm fine with not dumping in the text.
jmchilton
force-pushed
the
tool_test_error_handling
branch
2 times, most recently
from
ec3ec61
to
73487cc
Compare
bgruening
reviewed
Oct 17, 2024
| exc = None | ||
| try: | ||
| data_path = self.galaxy_interactor.test_data_path("cat1", "1.bed") | ||
| print(data_path) |
There was a problem hiding this comment.
Suggested change
| print(data_path) |
- Add integration test for invalid admin key. - Add tool test to ensure error message is valid JSON. - Swap order of require_admin and expose_api - expose_api sets environment so require_admin knows it should return JSON and not HTML. This is the bug fix.
jmchilton
force-pushed
the
tool_test_error_handling
branch
from
73487cc
to
02a817d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test the changes?
(Select all options that apply)
License