Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public name validation to allow upper-case letters #19100

Closed

Conversation

arash77
Copy link
Collaborator

@arash77 arash77 commented Nov 4, 2024

Enhance the public name validation to accept upper-case letters, ensuring a broader range of valid names. Adjusted related error messages accordingly.
Fixes #19087

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.2 milestone Nov 4, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Nov 5, 2024

Usernames should be lowercase, I don't think a bug in casting them to lowercase should dictate that we now allow this.

@arash77
Copy link
Collaborator Author

arash77 commented Nov 5, 2024

So I will just close this PR.

@arash77 arash77 closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 when sharing history if username has capital letters
2 participants