[24.0] Optimize/fix sqlite hid update statement #19106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those failures seem unrelated |
mvdbeek
force-pushed
the
sqlite_fix_workflow_test
branch
from
9f3f26e
to
310130c
Compare
`./run_tests.sh --skip-common-startup -api lib/galaxy_test/api -- -s -k cache` would fail on sqlite with database locked. Not using a separate connection means that we expire loaded attributes in the sqlite case, but I don't think we need to be concerned about performance if you're using sqlite.
mvdbeek
force-pushed
the
sqlite_fix_workflow_test
branch
from
310130c
to
71e499b
Compare
nsoranzo
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./run_tests.sh --skip-common-startup -api lib/galaxy_test/api -- -s -k cachewould fail on sqlite with database locked.Not using a separate connection means that we expire loaded attributes in the sqlite case, but I don't think we need to be concerned about performance if you're using sqlite.
How to test the changes?
(Select all options that apply)
run
./run_tests.sh --skip-common-startup -api lib/galaxy_test/api -- -s -k cacheand see that it doesn't failLicense