Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test hash validation also for upload by path #19109

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Nov 5, 2024

Also:

  • Add some related type annotations

Questions / future work:

  1. Currently setting validate_hashes to True in the request is required, I think we should just validate the hashes if they are part of the request
  2. If a hash doesn't validate, we currently only add an error_message but the dataset state remains ok, seems wrong to me?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nsoranzo nsoranzo merged commit 242c533 into galaxyproject:dev Nov 5, 2024
55 checks passed
@nsoranzo nsoranzo deleted the path_upload_check_hashes branch November 5, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants