Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider exclude in shed update #1106

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Dec 6, 2020

by considering exclude when

  • build and downloading tar balls
  • diff

shed update should now consider exclude in .shed.yml

I checked this (a1e2cae) in the following way on the TTS.

Afterwards the file was gone again (on the TTS).

Would be great to have for updating the OpenMS tools (where we have quite a few extra files in the TS that shouldn't be there, i.e. we would like to remove them from the TS and not consider them for the question if a repo should be updated).

TODO(?):

may fix: #554

by considering exlude when

- build and downloading tar balls
- diff

shed update should now consider exclude in .shed.yml
@bernt-matthias bernt-matthias removed the wip label Dec 6, 2020
@jmchilton
Copy link
Member

This looks good to me, is it ready to be merged?

@bernt-matthias
Copy link
Contributor Author

This looks good to me, is it ready to be merged?

Wondering about the questions in the TODOs. In particular question 2.

Is there anything that deserves a test in this changes? If yes ideas?

@nsoranzo
Copy link
Member

nsoranzo commented Dec 7, 2020

build_tarball is also used in planemo/commands/cmd_shed_build.py , so that needs to be also updated or exclude made optional.

@bernt-matthias
Copy link
Contributor Author

build_tarball is also used in planemo/commands/cmd_shed_build.py , so that needs to be also updated or exclude made optional.

No problem, but I'm still quite confused by the code. It seems that RawRepositoryDirectory already considers excludes (

excludes = _shed_config_excludes(config)
) partially (for instance not in _realized_files) but RealizedRepositry not (btw. do we want to fix the typo).

Both tools essentially start by calling shed.for_each_repository -> _realize_effective_repositories -> there _find_raw_repositories constructs RawRepositoryDirectorys which are then turned into RealizedRepositry. So I guess the excludes could be ignored in the calls to build_tarball from the commands.

Is this correct?

@jmchilton
Copy link
Member

I don't remember all the details - but the idea is that the raw directory structures are materialized into effective repository structures with includes and excludes handled and tools and tool-data demultiplexed. So should any of this be needed? Maybe exclude is only used for automatic demultiplexing though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planemo uploads to the Tool Shed include unwanted files
3 participants