Validate with jsonschema #1417
Validate with jsonschema #1417
Conversation
In general I don't think this strategy works at all, we don't have information about optionality in the workflow export.
|
Can you document some where how |
| @@ -21,10 +21,10 @@ | |||
| text: Word | |||
| second: | |||
| asserts: | |||
| - that: has_text | |||
There was a problem hiding this comment.
Does the version of this where these isn't a list - but it is just a dictionary keyed on the assertion types validate? That seems to be what we have documented in: https://planemo.readthedocs.io/en/latest/test_format.html#test-format. I assume yes but I wanted to make sure.
I definitely prefer the a list of flat dictionaries with the fixed that keyword to a list of nested dictionaries each with a single outer key. The structure of this feels very... awkward or forced. Is this really the syntax you prefer or is JSON schema coercing us in this direction?
| "additionalProperties": false, | ||
| "description": "Asserts the output has a specific size (in bytes) of ``value`` plus minus\n``delta``, e.g. ``<has_size value=\"10000\" delta=\"100\" />``.\n\nAlternatively the range of the expected size can be specified by ``min`` and/or\n``max``.\n$attribute_list::5", | ||
| "properties": { | ||
| "value": { |
There was a problem hiding this comment.
Can you also add size ass synonym for value (as in galaxyproject/galaxy#17490)
| "has_size": { | ||
| "items": { | ||
| "$ref": "#/$defs/AssertHasSize" | ||
| }, | ||
| "title": "Has Size", | ||
| "type": "array" | ||
| }, |
There was a problem hiding this comment.
Instead of having all these assertions as properties we should have "children", which contain a list of assertions, or.
At least that's what the parser does : https://github.com/galaxyproject/galaxy/blob/9ddb6ad44afc59fadec39f5bdbf8e6b106774734/lib/galaxy/tool_util/parser/yaml.py#L291 .. or lets say is supposed to do (since the recursion is missing at the moment .. I guess this is easy to fix and I will try).
In hindsight it might have been better to just use "asserts" instead of "children" since its also the name of the top level list of asserts (or is this only in workflow tests).
There was a problem hiding this comment.
Just need to regenerate the schema, it's all derived from the xsd
There was a problem hiding this comment.
That was a comment on #1417 (comment) ...
I am not sure I understand the proposition here, this doesn't seem necessary as you can simply use a list of assertions ?
also
elementsin top level collection tests in addition toelement_tests(i've marked element_tests as deprecated in the schema)The schema disallows the
- that: has_textstyle assertions. They continue to work in tests but results in linting errrors, I hope that's ok. I've included the schema for now in planemo, but eventually we should either include it in galaxy-tool-util (as soon as pydantic 2 can be supported) or just publish the schema to https://www.schemastore.org/json/. The process seems easy enough, but we may need to come up with a more unique test file name (*.gxwf-test.yml) ?