Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Build mercurial 5.7.1 #81

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Build mercurial 5.7.1 #81

merged 2 commits into from
Aug 27, 2021

Conversation

abretaud
Copy link
Contributor

@abretaud abretaud commented Jul 2, 2021

While updating to 21.05 my galaxy tried (and failed) to build a mercurial 5.7.1 wheel locally, so I guess it needs to be rebuild here somehow?

image

@nsoranzo
Copy link
Member

nsoranzo commented Jul 2, 2021

Something changed in how auditwheel names its output file, which requires an update on our side, the rest looks good.

@abretaud
Copy link
Contributor Author

abretaud commented Jul 2, 2021

Ok good, thanks for looking at it :)
Just out of curiosity, is there some doc/training somewhere explaining why galaxy needs to have its own wheels built here?

@nsoranzo
Copy link
Member

nsoranzo commented Jul 2, 2021

It's not Galaxy's fault (for once), it's the upstream Python projects that don't provide the wheels on PyPI, in particular those that contain compiled extensions, which cannot be installed (or fully installed) without a compiler and Python development libraries.
An out-of-date list of offending packages is in #26

@abretaud
Copy link
Contributor Author

abretaud commented Jul 2, 2021

Ah ok I see 👍

@nsoranzo
Copy link
Member

The files produced by auditwheel now have names like mercurial-5.7.1-cp36-cp36m-manylinux_2_5_i686.manylinux1_i686.whl , where manylinux_2_5_i686 is an alias for manylinux1_i686 according to https://www.python.org/dev/peps/pep-0600/ .

@natefoo
Copy link
Member

natefoo commented Aug 27, 2021

Starforge has the ability to automatically detect the platform names. This repo just overrides that and hardcodes them in the Starforge config file though, so the commit I just pushed should fix it going forward?

@nsoranzo nsoranzo merged commit 10d82c6 into master Aug 27, 2021
@nsoranzo nsoranzo deleted the mercurial-5.7.1 branch August 27, 2021 19:04
@nsoranzo
Copy link
Member

Thanks @natefoo !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants