Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the extra WF step. Fixed instructions in model prediction #4676

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fixed the extra WF step. Fixed instructions in model prediction #4676

merged 1 commit into from
Feb 1, 2024

Conversation

kxk302
Copy link
Collaborator

@kxk302 kxk302 commented Jan 24, 2024

--> Please remove all this text before submitting your PR, it's just a checklist to help you :) <--

  1. Give your pull request a good title
    • e.g. "Fix typo in ansible-galaxy tutorial" or "Add new transcriptomics tutorial covering a new sequencing technology"
  2. Describe your changes in detail, list anything you still need some help with or things that are still TODO
  3. Check that your images are allowed to be re-hosted by the GTN!
  4. Still working on it? Make it a Draft pull request
    • Once it is ready, choose Ready for Review
    • Then the automated tests will run and we will know to review and merge it

@kxk302 kxk302 requested a review from a team as a code owner January 24, 2024 17:01
@kxk302
Copy link
Collaborator Author

kxk302 commented Jan 25, 2024

@anuprulez When you get a chance, could you please review this? Thanks!

afgane
afgane approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@afgane afgane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I tested the workflow on usegalaxy.org and it runs to completion as expected.

@kxk302 kxk302 merged commit 5e535a2 into galaxyproject:main Feb 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afgane afgane afgane approved these changes

Assignees
No one assigned
Labels
statistics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kxk302 @afgane