-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (carousel block): show inner column margins in frontend #3257
Conversation
🤖 Pull request artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a huge amount of changes that even adds to PHP overhead, just because the left/right margins are not showing in the frontend. Why are they not showing up in the first place?
This reverts commit 6be73bd.
@mxkae The fix didn't apply on my end. Is there any setting I need to apply to show the fix? 🤔 Screen.Recording.2024-08-15.at.3.mp4 |
@andeng1106 our fix is just to remove the ability to change the margins when inside columns since you can achieve the same results with containers |
fixes #3173