Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (icon list): editor freezes when adding patterns with icon list #3333

Merged
merged 2 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/block/icon-list-item/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ import { useBlockContext } from '~stackable/hooks'
import { __ } from '@wordpress/i18n'
import { compose, createHigherOrderComponent } from '@wordpress/compose'
import { dispatch } from '@wordpress/data'
import { useEffect, memo } from '@wordpress/element'
import {
useEffect, useRef, memo,
} from '@wordpress/element'

const TABS = [ 'style', 'advanced' ]

Expand All @@ -68,15 +70,28 @@ const Edit = props => {
'stackable/uniqueId': parentUniqueId,
} = context

const updateOrderedTimeout = useRef()
const updateUniqueIdTimeout = useRef()

// Set the attributes so they can be used in Save.
useEffect( () => {
dispatch( 'core/block-editor' ).__unstableMarkNextChangeAsNotPersistent()
setAttributes( { ordered } )
clearTimeout( updateOrderedTimeout.current )
if ( ordered !== props.attributes.ordered ) {
updateOrderedTimeout.current = setTimeout( () => {
dispatch( 'core/block-editor' ).__unstableMarkNextChangeAsNotPersistent()
setAttributes( { ordered } )
}, 300 )
}
}, [ ordered ] )

useEffect( () => {
dispatch( 'core/block-editor' ).__unstableMarkNextChangeAsNotPersistent()
setAttributes( { parentUniqueId } )
clearTimeout( updateUniqueIdTimeout.current )
if ( parentUniqueId !== props.attributes.parentUniqueId ) {
updateUniqueIdTimeout.current = setTimeout( () => {
dispatch( 'core/block-editor' ).__unstableMarkNextChangeAsNotPersistent()
setAttributes( { parentUniqueId } )
}, 300 )
}
}, [ parentUniqueId ] )

const blockClassNames = classnames( [
Expand Down
6 changes: 5 additions & 1 deletion src/block/icon-list/deprecated/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
deprecateBlockBackgroundColorOpacity, deprecateContainerBackgroundColorOpacity, deprecateTypographyGradientColor,
deprecateBlockShadowColor, deprecateContainerShadowColor,
} from '~stackable/block-components'
import { createUniqueClass } from '~stackable/util'

import { createBlock } from '@wordpress/blocks'

Expand Down Expand Up @@ -109,10 +110,13 @@ const deprecated = [
} else {
const contents = textToArray( text )
const blocks = contents.map( ( content, index ) => {
return createBlock( 'stackable/icon-list-item', {
const newBlock = createBlock( 'stackable/icon-list-item', {
text: content,
icon: getUniqueIcon( icons, index ),
} )
newBlock.attributes.uniqueId = createUniqueClass( newBlock.clientId )

return newBlock
} )
innerBlocks = blocks
}
Expand Down
2 changes: 1 addition & 1 deletion src/block/icon-list/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ const Edit = props => {
className={ blockClassNames }
>
{ ! ordered && <IconSvgDef icon={ icon } uniqueId={ attributes.uniqueId } /> }
<ParentTagName { ...innerBlocksProps } >
<ParentTagName className={ tagNameClassNames } >
{ wrapList &&
<TagName className="stk-block-icon-list__group">
{ innerBlocksProps.children }
Expand Down
Loading