fix: add IL2CPP_ADDITIONAL_ARGS for 2019.3.x-linux-il2cpp
#63
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
editor/Dockerfile
Outdated
Comment on lines
57
to
67
| #======================================================================================= | ||
| # [2019.3.x-linux-il2cpp] IL2CPP_ADDITIONAL_ARGS='--sysroot-path=/ --tool-chain-path=/' | ||
| # https://forum.unity.com/threads/unity-2019-3-linux-il2cpp-player-can-only-be-built-with-linux-error.822210/#post-5633977 | ||
| #======================================================================================= | ||
| RUN [ `echo $version-$module | grep -v '^2019.3.*-linux-il2cpp'` ] && exit 0 || : \ | ||
| && { \ | ||
| echo '#!/bin/bash'; \ | ||
| echo 'export IL2CPP_ADDITIONAL_ARGS="--sysroot-path=/ --tool-chain-path=/"'; \ | ||
| echo 'xvfb-run -ae /dev/stdout "$UNITY_PATH/Editor/Unity" -batchmode "$@"'; \ | ||
| } > /usr/bin/unity-editor \ | ||
| && chmod +x /usr/bin/unity-editor |
There was a problem hiding this comment.
Since this seems to be the only correct workaround, I would consider this not an "extra step".
Instead I think this should be part of the run command at line 38 if possible. Otherwise, perhaps immediately after.
My suggestion would be to use some kind of if-elseif-else clause where we can customise /usr/bin/unity-editor and default to the existing one.
There was a problem hiding this comment.
OK, I'll follow your suggestion. 👍
There was a problem hiding this comment.
For example:
RUN { \
echo '#!/bin/bash'; \
echo ''; \
\
[ `echo $version-$module | grep -e '^2019.3.*-linux-il2cpp'` ] \
&& echo '# [2019.3.x-linux-il2cpp] https://forum.unity.com/threads/unity-2019-3-linux-il2cpp-player-can-only-be-built-with-linux-error.822210/#post-5633977' \
&& echo 'export IL2CPP_ADDITIONAL_ARGS="--sysroot-path=/ --tool-chain-path=/"' \
&& echo ''; \
\
echo 'xvfb-run -ae /dev/stdout "$UNITY_PATH/Editor/Unity" -batchmode "$@"'; \
} > /usr/bin/unity-editor \
&& chmod +x /usr/bin/unity-editorGenerated unity-editor for 2019.3.x-linux-il2cpp
#!/bin/bash
# [2019.3.x-linux-il2cpp] https://forum.unity.com/threads/unity-2019-3-linux-il2cpp-player-can-only-be-built-with-linux-error.822210/#post-5633977
export IL2CPP_ADDITIONAL_ARGS="--sysroot-path=/ --tool-chain-path=/"
xvfb-run -ae /dev/stdout "$UNITY_PATH/Editor/Unity" -batchmode "$@"Otherwise
#!/bin/bash
xvfb-run -ae /dev/stdout "$UNITY_PATH/Editor/Unity" -batchmode "$@"Tested with #60 (in my repo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IL2CPP_ADDITIONAL_ARGS="--sysroot-path=/ --tool-chain-path=/".Checklist
Versions and modules to be fixed
Tested with #60 (in my repo)
Increased image size
< 1 KB