Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating FontAwesome Icons in Admin area #3193

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

N8Solutions
Copy link

@N8Solutions N8Solutions commented Oct 21, 2023

Some FontAwesome icons do not work properly when J2Store is added to Joomla. This happens whether in J3 or J4. These changes are for compatibility with newer versions of Joomla and FontAwesome 5.

J2Store can be downloaded for free from here:
https://github.com/J2Store4/j2store4/releases

Icons that get broken:

  • arrows for the spacer particle
  • TM (trademark) for the branding particle
  • For other particles that utilize the pencil, copy, trash FA icons

For the Branding particle located in:
engines\common\nucleus\particles
and the files
branding.yaml
branding.html.twig

In Gantry 5 the branding particle has the class fa fa-fw fa-trademark on the left side menu of particles but fas fa-fw fa-trademark is more compatible. When the branding particle is added to a layout, it again has the class fa fa-trademark, and changing it to fas fa-trademark fixes the problem. However, I'm unable to figure out where to make these changes for this particle so it displays properly.

These changes fix the issue and they are still compatible with a fresh install of Gantry 5. Just need to fix the Branding particle.

Some FontAwesome icons do not work properly when other extensions are added to Joomla. These changes are for compatability with newer versions of Joomla and FontAwesome 5.

Some important icons get broken sometimes
arrows for the spacer particle
TM (trademark) for the branding particle
For other particles that utilize the pencil, copy, trash FA icons

For the Branding particle located in:
engines\common\nucleus\particles
branding.yaml
branding.html.twig

In the Gantry 5 it has the class "fa fa-fw fa-trademark" on the left side menu of particles but "fas fa-fw fa-trademark" is more compatible. When the branding particle is added to a layout, it again has the class "fa fa-trademark", and changing it to "fas fa-trademark" fixes the problem. However, I'm unable to figure out where to make these changes for this particle so it displays properly.

I am uanble to pinpoint exactly what extensions trigger this issue but I do know making these changes fixes it and the changes are still compatible with a fresh install of Gantry 5. Just need to fix the Branding particle.
@N8Solutions
Copy link
Author

@JoomFX I wanted to bring this pull request to your attention as well. Thought you'd like to check out the suggested changes I've made to fix the issue. I'm hoping @hexplor will review and include these changes for the next version of Gantry 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant