Add violation for StringReader

gaul · Dec 1, 2024 · 6f5a64f · 6f5a64f
1 parent 41f7f5a
commit 6f5a64f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/modernizer-maven-plugin/src/main/resources/modernizer.xml b/modernizer-maven-plugin/src/main/resources/modernizer.xml
@@ -425,6 +425,12 @@ violation names use the same format that javap emits.
     <comment>Prefer java.io.OutputStreamWriter(java.io.OutputStream, java.nio.charset.Charset)</comment>
   </violation>
 
+  <violation>
+    <name>java/io/StringReader."&lt;init&gt;":(Ljava/lang/String;)V</name>
+    <version>24</version>
+    <comment>Prefer java.io.Reader.of(java.lang.CharSequence)</comment>
+  </violation>
+
   <violation>
     <name>java/lang/Byte."&lt;init&gt;":(B)V</name>
     <version>5</version>

diff --git a/modernizer-maven-plugin/src/test/java/org/gaul/modernizer_maven_plugin/ModernizerTest.java b/modernizer-maven-plugin/src/test/java/org/gaul/modernizer_maven_plugin/ModernizerTest.java
@@ -28,6 +28,7 @@
 import java.io.OutputStreamWriter;
 import java.io.PrintStream;
 import java.io.PrintWriter;
+import java.io.StringReader;
 import java.net.HttpURLConnection;
 import java.net.NetworkInterface;
 import java.net.URLDecoder;
@@ -399,7 +400,7 @@ public void testAnnotationViolation() throws Exception {
 
     @Test
     public void testAllViolations() throws Exception {
-        Modernizer modernizer = createModernizer("19");
+        Modernizer modernizer = createModernizer("24");
         Collection<ViolationOccurrence> occurrences = modernizer.check(
                 new ClassReader(AllViolations.class.getName()));
         occurrences.addAll(modernizer.check(
@@ -418,6 +419,8 @@ public void testAllViolations() throws Exception {
             new ClassReader(Java18Violations.class.getName())));
         occurrences.addAll(modernizer.check(
             new ClassReader(Java19Violations.class.getName())));
+        occurrences.addAll(modernizer.check(
+            new ClassReader(Java24Violations.class.getName())));
         // must visit inner classes manually
         occurrences.addAll(modernizer.check(
                 new ClassReader(EnumerationTestClass.class.getName())));
@@ -847,6 +850,12 @@ private static void method() throws Exception {
         }
     }
 
+    private static class Java24Violations {
+        private static void method() throws Exception {
+            new StringReader("");
+        }
+    }
+
     private enum EnumClass {
     }
 }