Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RenderEngineManager's inheritance from Singleton base class #874

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 25, 2023

🦟 Bug fix

Summary

Related PR: #734.

Implements the ABI breaking change as mentioned in the todo note added in #734.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #874 (916730a) into main (9a76f1f) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 916730a differs from pull request most recent head 4619316. Consider uploading reports for the commit 4619316 to get more accurate results

@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   75.10%   75.10%           
=======================================
  Files         176      176           
  Lines       16853    16853           
=======================================
  Hits        12658    12658           
  Misses       4195     4195           
Files Changed Coverage Δ
src/RenderEngineManager.cc 76.89% <100.00%> (ø)

@ahcorde ahcorde merged commit c96cefd into main Jul 26, 2023
6 checks passed
@ahcorde ahcorde deleted the renderenginemgr_singleton branch July 26, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants