Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --background #1508

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Implement --background #1508

wants to merge 1 commit into from

Conversation

ISSOtm
Copy link
Member

@ISSOtm ISSOtm commented Sep 18, 2024

TODO: document the behaviour, and add tests!

TODO: document the behaviour
@ISSOtm ISSOtm requested a review from Rangi42 September 18, 2024 16:59
@@ -3,6 +3,7 @@
#include "gfx/process.hpp"

#include <algorithm>
#include <cstdint>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already has <stdint.h>.

Suggested change
#include <cstdint>

@@ -1152,6 +1166,28 @@ void process() {
continue;
}

if (options.bgColor.has_value()) {
switch (tileColors.compare(bgPal)) {
case ProtoPalette::THEY_BIGGER: // Note that ties are resolved as `THEY_BIGGER`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite surprising; what's ProtoPalette::NEITHER for then?

@Rangi42 Rangi42 added this to the v0.9.0 milestone Oct 2, 2024
@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbgfx This affects RGBGFX labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Typically new features; lesser priority than bugs rgbgfx This affects RGBGFX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants