Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch in Integrity Value for JavaScript File #72

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

JayanthyChengan
Copy link

Related to
#69

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things:

  • the policy so far has been to only make changes in the betatest folder, so I'd ask you to edit previewers/betatest/MapShpPreview.html instead. It would make sense to send a community email to let admins know that they need to update.
  • the leaflet script appears to be from the same person and also released w/o a version number - does it make sense to remove the integrity there to to avoid a similar issue?
  • Can you add a comment in the file saying ~ integrity values have been removed from the next two scripts because the author updates them without including version info in the name. You may want to make a local install to avoid unexpected changes. See https://github.com/gdcc/dataverse-previewers#fully-local-installation

JayanthyChengan and others added 3 commits July 2, 2024 12:12
…le javascripts because the author updates them without including version information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants