Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BS html.parser error #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed BS html.parser error #17

wants to merge 1 commit into from

Conversation

jbdoster
Copy link

@jbdoster jbdoster commented Jul 4, 2018

Really simple, Beautiful Soup was raising an issue about not explicitly specifying an HTML parser.
brahmcapoor did a similar PR, but I don't know if it ever passed travis.

So from:
screen shot 2018-07-03 at 9 02 40 pm

To:
screen shot 2018-07-03 at 9 02 56 pm

Please note that it still doesn't find the appropriate synonyms.

EDIT:
I'm still new to CI and travis, but I saw this error message:
nose.proxy.AssertionError: None is not an instance of <class 'list'>

Is this because each listed synonym string is under it's own individual span tag in the markup?

screen shot 2018-07-03 at 9 05 28 pm

The code is currently scanning for child list items directly under this div container:

screen shot 2018-07-03 at 9 05 00 pm

Either way that's why my travis tests failed.
That's for another PR I think.. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant